Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped Character highlighting support inside string literals. #13

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmranMR
Copy link

@EmranMR EmranMR commented Sep 30, 2023

Hello!
This pull request adds highlighting support for escape characters. Currently Nova does not have a specific theming selector for these characters like the regex.escaped, or the string.escape that was written in objc/highlights.scm

I followed your convention of using @value.number for char values, so that the theming is consistent across.

  • I have seen this in other editors and it's extremely beneficial to relieve eye strain 😵‍💫 , esp in printf style functions!
  • I did the same for Objective C, swift and C.

PS. I am very new to C family programming language and barely touched the surface with C++. I gave it a shot myself in all the languages and it seem to work fine. However I found a parsing bug 🐞 while I was testing, very likely due to core Nova, Unrelated to this extension or tree-sitter 🌳 and I will raise it via the form on Nova.app. Other than that it worked as expected on my side! 😊

Screenshot 2023-09-30 at 11 38 08

👇👇👇👇👇👇

Screenshot 2023-09-30 at 11 38 22

@EmranMR EmranMR changed the title Escaped Character highlighting Support inside string literals. Escaped Character highlighting support inside string literals. Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant