[Flink] Add option to use JobManager to store history of jobs #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ngeo-forge-runner into gcorradini/historyserver
for more information, see https://pre-commit.ci
…ngeo-forge-runner into gcorradini/historyserver
for more information, see https://pre-commit.ci
ranchodeluxe
added
the
test-flink
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
+ Coverage 96.36% 96.44% +0.07%
==========================================
Files 15 15
Lines 495 506 +11
==========================================
+ Hits 477 488 +11
Misses 18 18 ☔ View full report in Codecov by Sentry. |
yuvipanda
requested changes
Nov 28, 2023
yuvipanda
reviewed
Nov 28, 2023
There was a problem hiding this comment.
The changes look good to me. One minor suggestion, will merge after that.
Thanks for incorporating this, @ranchodeluxe!
yuvipanda
approved these changes
Nov 28, 2023
yuvipanda
changed the title
|
Thanks @ranchodeluxe! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mount EFS to Job Managers so they can archive jobs for historical status lookups
Addresses #122
Related PR: pangeo-forge/pangeo-forge-cloud-federation#6