address comments

helm-charts/flink-historyserver/templates/efs.yaml

@@ -1,7 +1,7 @@
 apiVersion: storage.k8s.io/v1
 kind: StorageClass
 metadata:
-  name: {{ .Release.Name }}-efs-flink-history
+  name: {{ .Release.Name }}-efs-flink-history-sc
 parameters:
   provisioningMode: efs-ap
   fileSystemId: "{{- .Values.efsFileSystemId }}"
@@ -10,7 +10,7 @@ provisioner: "efs.csi.aws.com"
 apiVersion: v1
 kind: PersistentVolume
 metadata:
-  name: flink-historyserver-efs-pv
+  name: {{ .Release.Name }}-flink-historyserver-efs-pv
 spec:
   capacity:
     storage: "1Mi"
@@ -31,7 +31,7 @@ metadata:
 spec:
   accessModes:
     - ReadWriteMany
-  storageClassName: {{ .Release.Name }}-efs-flink-history
+  storageClassName: {{ .Release.Name }}-efs-flink-history-sc
   resources:
     requests:
       storage: 1Mi

helm-charts/flink-historyserver/templates/historyserver.yaml

@@ -32,12 +32,7 @@ spec:
           name: history
           protocol: TCP
         resources:
-          limits:
-            cpu: 300m
-            memory: 1536Mi
-          requests:
-            cpu: 300m
-            memory: 1536Mi
+{{ toYaml .Values.resources | indent 10 }}
         startupProbe:
           httpGet:
             path: /config
@@ -90,5 +85,3 @@ spec:
   selector:
     app: historyserver
   type: ClusterIP
-status:
-  loadBalancer: {}

helm-charts/flink-historyserver/values.schema.json

@@ -4,8 +4,7 @@
   "required": ["efsFileSystemId"],
   "properties": {
     "efsFileSystemId": {
-      "type": "string",
-      "minLength": 1
+      "type": "string"
     }
   }
 }

helm-charts/flink-historyserver/values.yaml

@@ -1,2 +1,8 @@
-efsFileSystemId: ""
-flinkVersion: "1.16"
+flinkVersion: "1.16"
+resources:
+  limits:
+    cpu: 300m
+    memory: 1536Mi
+  requests:
+    cpu: 300m
+    memory: 1536Mi