-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resample idx #354
resample idx #354
Conversation
This looks great @aaronspring. Just some nitpicky naming stuff to make things more clear for future development and a question about this zero issue in the resampling dimension. Tested some on Cheyenne and it's all running fast. This will set things up nicely to implement this in bootstrapping for skill. |
I change now got bigger as I replaced the |
bigger performance increase ever. 0.02 is a 50x increase. I would have expected to see this in the next PR, but we also see this here already.
EDIT. there must be something wrong with this. the next PR will have some serious |
and I didnt touch the documentation here where it fails. the new file |
Description
This implements the index based resampling developed by @ahuang11 and @bradyrx for the stats threshold functions. Next PR would refactor bootstrap: first resample (based on
resample_idx
) input, then apply metric, see https://github.com/bradyrx/climpred/pull/355also added new
asv
benchmarks for 1D databreaking change: keyword change:
bootstrap
->iterations
works on #145
Type of change
Please delete options that are not relevant.
asv
to detect performance changes)How Has This Been Tested?
Please describe the tests that you ran to verify your changes. This could point to a cell in the updated notebooks. Or a snippet of code with accompanying figures here.
Checklist (while developing)
pytest
, if necessary.Pre-Merge Checklist (final steps)
References
your gist