Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove coveralls token #343

Merged
merged 7 commits into from
Mar 20, 2020
Merged

Remove coveralls token #343

merged 7 commits into from
Mar 20, 2020

Conversation

bradyrx
Copy link
Collaborator

@bradyrx bradyrx commented Mar 16, 2020

Description

Removes the coveralls.yml file with our token, since that's not supposed to be public (https://stackoverflow.com/questions/39501417/how-can-i-connect-coveralls-and-travis-in-github). Travis should be able to handle connecting to coveralls, since we're a public repo.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Mar 16, 2020

Hm, it looks like I need that token for things to work. I'll play around with this later.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Mar 20, 2020

Trying the simple steps from here: https://github.com/coveralls-clients/coveralls-python.

@coveralls
Copy link

coveralls commented Mar 20, 2020

Coverage Status

Coverage remained the same at 91.531% when pulling 4a40875 on encrypt into d82f115 on master.

@bradyrx
Copy link
Collaborator Author

bradyrx commented Mar 20, 2020

Thanks @andersy005 for the heads up on this. It looks like with a public repo and Travis, the token is passed behind the scenes to coveralls. You just need the repo token if you're private or using travis pro.

@bradyrx bradyrx merged commit 5370e6b into master Mar 20, 2020
@bradyrx bradyrx deleted the encrypt branch March 20, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants