Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AS bootstrap faster #319

Closed
wants to merge 4 commits into from
Closed

AS bootstrap faster #319

wants to merge 4 commits into from

Conversation

aaronspring
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Closes #145

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Performance (if you touched existing code run asv to detect performance changes)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. This could point to a cell in the updated notebooks. Or a snippet of code with accompanying figures here.

Checklist (while developing)

  • I have added docstrings to all new functions.
  • I have commented my code, particularly in hard-to-understand areas
  • Tests added for pytest, if necessary.
  • I have updated the sphinx documentation, if necessary.

Pre-Merge Checklist (final steps)

  • I have rebased onto master or develop (wherever I am merging) and dealt with any conflicts.
  • I have squashed commits to a reasonable amount, and force-pushed the squashed commits.

References

Please add any references to manuscripts, textbooks, etc.

@aaronspring aaronspring self-assigned this Feb 8, 2020
@aaronspring
Copy link
Collaborator Author

I just have this branch to transfer the code between the supercomputer and my local to develop

@aaronspring
Copy link
Collaborator Author

on the supercomputer:

       before           after         ratio
     [a3dc46f6]       [5310e829]
     <319>            <master>
-       4.22±0.1s       3.03±0.04s     0.72  benchmarks_hindcast.ComputeDask.time_bootstrap_hindcast('rmse', 'm2o')
-      4.49±0.08s       3.15±0.03s     0.70  benchmarks_hindcast.ComputeDask.time_bootstrap_hindcast('pearson_r', 'm2o')
-      6.43±0.08s       3.28±0.05s     0.51  benchmarks_hindcast.ComputeDask.time_bootstrap_hindcast('crpss', 'm2o')

@bradyrx
Copy link
Collaborator

bradyrx commented Mar 3, 2020

Does this need to stay open @aaronspring? You can close it and keep the branch alive so you can switch to it if you need to.

@aaronspring aaronspring closed this Mar 3, 2020
@aaronspring aaronspring deleted the AS_bootstrap_faster branch March 3, 2020 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallelize bootstrap
2 participants