ENH: Add StringMethods.isnumeric and isdecimal #9439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinhrks
force-pushed
the
string_isnumeric
branch
from
c4d3505 to
0046100
Compare
24 tasks
| # 0x2605: ★ not number | ||
| # 0x1378: ፸ ETHIOPIC NUMBER SEVENTY | ||
| # 0xFF13: ３ Em 3 | ||
| values = ['A', '3', unichr(0x00bc), unichr(0x2605), |
There was a problem hiding this comment.
ugh... I guess we still support Python 3.2 :(
There was a problem hiding this comment.
Isn't 3.2 tested in below? I've expected compat.unichr can work for 3.2 also.
There was a problem hiding this comment.
I know, it works!
I was going to suggest just using u'¼' but the u unicode literal is not supported on Python 3.2.
There was a problem hiding this comment.
I see. I also tried to use u at first and failed... Will wait a conclusion of #9118.
There was a problem hiding this comment.
u(...) is the way to handle 3.2 compat
There was a problem hiding this comment.
I think we can't use u( ) here because escaped unicode is not handled as numeric or decimal.
jreback
added a commit
that referenced
this pull request
Feb 10, 2015
ENH: Add StringMethods.isnumeric and isdecimal
|
thanks! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Derived from #9111.