Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: make Series.sort/order arguments in the same order #6848

Merged
merged 1 commit into from
Apr 9, 2014
Merged

API: make Series.sort/order arguments in the same order #6848

merged 1 commit into from
Apr 9, 2014

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Apr 9, 2014

  • drop unused Series.sort order argument
  • added Series.sort na_position argument to conform with Series.order
  • default kind for Series.order is now quicksort, same as Series.sort and numpy default

closes #6847

@jreback jreback added this to the 0.14.0 milestone Apr 9, 2014
@jreback
Copy link
Contributor Author

jreback commented Apr 9, 2014

cc @unutbu

@jreback
Copy link
Contributor Author

jreback commented Apr 9, 2014

any objections here?

@jtratner @cpcloud @jorisvandenbossche @hayd

@jreback
API: make Series.sort/order arguments in the same order
86bc2e3 
     drop unused Series.sort order argument
     added Series.sort na_position argument to conform with Series.order
     Series.order default kind is not 'quicksort' to conform with Series.sort
     (and others), (GH6847)
@cpcloud
Copy link
Member

cpcloud commented Apr 9, 2014

fine by me

@hayd
Copy link
Contributor

hayd commented Apr 9, 2014

👍

jreback added a commit that referenced this pull request Apr 9, 2014
@jreback
Merge pull request #6848 from jreback/sort
6387f38 
API: make Series.sort/order arguments in the same order
@jreback jreback merged commit 6387f38 into pandas-dev:master Apr 9, 2014
@jorisvandenbossche
Copy link
Member

Are sort and order now fully equivalent? (apart from that sort is inplace and ordernot?) Maybe this should be added to the docstrings (eg a "See also")

@jreback
Copy link
Contributor Author

jreback commented Apr 10, 2014

yes, good point

@jreback
Copy link
Contributor Author

jreback commented Apr 10, 2014

fixed in c1440e9

as an aside, maybe we should add an inplace argument to sort=True (so if False it will return order)?

@jorisvandenbossche
Copy link
Member

And then also in order the other way around with inplace=False?

@jreback
Copy link
Contributor Author

jreback commented Apr 10, 2014

I think that is right....seems innocuous enough (famous last words)...will make an issue

@jreback jreback mentioned this pull request Apr 10, 2014
Closed
@armaganthis3 armaganthis3 mentioned this pull request Jul 14, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Design Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

API: default sort kind
4 participants
@jreback @cpcloud @hayd @jorisvandenbossche