Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout support in plot_frame similar to the hist_frame layout #6667

Closed
wants to merge 1 commit into from

Conversation

pascal-schetelat
Copy link

Add an optional layout keyword argument in order to set the subplots layout.
If none provided, falls back to default behavior.

Add an optional layout keyword argument in order to set the subplots layout
@jreback
Copy link
Contributor

jreback commented Mar 19, 2014

  • This needs a couple of tests which test passing an invalid layout.
  • Pls add a mention in release notes (refereing this PR #)

@jreback jreback added this to the 0.14.0 milestone Mar 19, 2014
@jorisvandenbossche
Copy link
Member

You will also have to expose this in plot_frame (https://github.com/pascal-schetelat/pandas/blob/master/pandas/tools/plotting.py#L1827) to make it usable in df.plot()

@pascal-schetelat
Copy link
Author

@jreback I duplicated the same tests on the layout as in hist_frame in _get_layout. Do you think additional tests are required?

@jorisvandenbossche you mean adding an entry in the doc or explicitely passing a layout argument in plot_frame?

@jorisvandenbossche
Copy link
Member

@pascal-schetelat Yes, at least adding it to the docs.
I also meant to explicitly pass it as a argument, but I see that there are also others that are passed through the *kwds, so I am not really sure about this what is best.

@jreback
Copy link
Contributor

jreback commented Mar 22, 2014

@pascal-schetelat this will close #6306, yes?

@jreback
Copy link
Contributor

jreback commented Apr 9, 2014

@pascal-schetelat pls rebase and push again, your changes are not showing up here

@jreback jreback modified the milestones: 0.15.0, 0.14.0 Apr 9, 2014
@sinhrks
Copy link
Member

sinhrks commented May 4, 2014

I think the shape of returned axes should be cared. hist returns ndarray which has the same shape as the specified layout, not flattened. Personally whichever possible if there is a policy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants