replace twitter->X #60426
Merged
replace twitter->X #60426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Nov 26, 2024
|
Thanks @partev |
|
the icon doesn't seem to be displaying correctly: @mroeschke the problem is that twitter-x icon was added in fontawesome 6.4.2 https://fontawesome.com/changelog, while pandas website uses 6.1.2 how can we upgrade fontawesome? |
partev
added a commit
to partev/pandas
that referenced
this pull request
Nov 27, 2024
upgrade PyData Sphinx Theme from 0.14 to the latest 0.16 it is needed to get the latest font-awesome pack to be able to display the new twitter-x icon. pandas-dev#60426
5 tasks
mroeschke
pushed a commit
that referenced
this pull request
Dec 2, 2024
* upgrade to the latest version of PyData Sphinx Theme upgrade PyData Sphinx Theme from 0.14 to the latest 0.16 it is needed to get the latest font-awesome pack to be able to display the new twitter-x icon. #60426 * update pydata-sphinx-theme to version 0.16 update pydata-sphinx-theme to version 0.16 and synchronize with environment.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sphinx theme prefers using "icon_links" instead of custom keywords
https://github.com/pydata/pydata-sphinx-theme/blob/main/docs/conf.py#L165