BUG: fix NameError raised when specifying dtype with string having "[pyarrow]" while PyArrow is not installed #60413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanx749
commented
Nov 25, 2024
| @@ -2344,6 +2344,8 @@ def construct_from_string(cls, string: str) -> ArrowDtype: | |||
| if string == "string[pyarrow]": | |||
| # Ensure Registry.find skips ArrowDtype to use StringDtype instead | |||
| raise TypeError("string[pyarrow] should be constructed by StringDtype") | |||
| if pa_version_under10p1: | |||
| raise ImportError("pyarrow>=10.0.1 is required for ArrowDtype") | |||
There was a problem hiding this comment.
These lines follow the error raised in ArrowDtype:
pandas/pandas/core/dtypes/dtypes.py
Lines 2194 to 2195 in ee0902a
mroeschke
reviewed
Nov 25, 2024
mroeschke
approved these changes
Nov 27, 2024
|
Thanks @yuanx749 |
tasfia8
pushed a commit
to tasfia8/pandas-tasfia8
that referenced
this pull request
Nov 28, 2024
…pyarrow]" while PyArrow is not installed (pandas-dev#60413) * Add test * Fix * Add note * Update pandas/tests/dtypes/test_common.py Co-authored-by: Matthew Roeschke <[email protected]> * update * Fix doc warning --------- Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thinks this is more like a bug than enhancement, as quoted from the OP:
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.