Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: preserve (object) dtype in factorize #60118

Merged
merged 3 commits into from
Oct 31, 2024
Merged

BUG: preserve (object) dtype in factorize #60118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70b0855
BUG: preserve (object) dtype in factorize
jorisvandenbossche Oct 28, 2024
ae5b1b5
Merge remote-tracking branch 'upstream/main' into factorize-preserve-…
jorisvandenbossche Oct 31, 2024
0c94a62
add fallback for float16
jorisvandenbossche Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pandas/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
from pandas.core.dtypes.generic import (
ABCDataFrame,
ABCIndex,
ABCMultiIndex,
ABCSeries,
)
from pandas.core.dtypes.missing import (
Expand Down Expand Up @@ -1287,13 +1288,18 @@ def factorize(
if uniques.dtype == np.float16:
uniques = uniques.astype(np.float32)

if isinstance(self, ABCIndex):
# preserve e.g. MultiIndex
if isinstance(self, ABCMultiIndex):
# preserve MultiIndex
uniques = self._constructor(uniques)
else:
from pandas import Index

uniques = Index(uniques)
try:
uniques = Index(uniques, dtype=self.dtype)
except NotImplementedError:
# not all dtypes are supported in Index that are allowed for Series
# e.g. float16 or bytes
uniques = Index(uniques)
return codes, uniques

_shared_docs["searchsorted"] = """
Expand Down
1 change: 0 additions & 1 deletion pandas/tests/test_algos.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,6 @@ def test_factorize_complex(self):
expected_uniques = np.array([(1 + 0j), (2 + 0j), (2 + 1j)], dtype=complex)
tm.assert_numpy_array_equal(uniques, expected_uniques)

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)", strict=False)
def test_factorize(self, index_or_series_obj, sort):
obj = index_or_series_obj
result_codes, result_uniques = obj.factorize(sort=sort)
Expand Down