-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport #59144 on 2.2.x / 2.3.x (remove ops div class to solve #2137) #59535
Conversation
…olve pandas-dev#2137) * remove core.computation.ops.Div resolves pandas-dev#21374 pandas-dev#58748 * need to preserve order * updating tests * (update whatsnew -- no whatsnew for 2.2.x and 2.3 yet) * solve mypy issue * fixing pytests * better than cast * adding specific test (* Update pandas/tests/frame/test_query_eval.py // Not backported, fails on 2.2) Co-authored-by: Matthew Roeschke <[email protected]> * Update pandas/tests/computation/test_eval.py Co-authored-by: Matthew Roeschke <[email protected]> --------- Co-authored-by: Laurent Mutricy <[email protected]> Co-authored-by: Matthew Roeschke <[email protected]>
81e2b2e
to
495c9ed
Compare
@WillAyd - 2.3.x should only have backports related to PDEP-14, is that right? |
If that's your policy, be advised that the current stable release 2.2 is not and minor release updates of it will never fully work with Numpy 2 |
There's a few things not required for PDEP-14 that have made their way in just to get the test suite green, but mostly it is for PDEP-14. We actually haven't started backporting anything yet to 2.3 - the first PR to do so an get that branch up to speed is #59513 I'll take a look at this particular change as part of that |
Thanks @WillAyd - I wouldn't push for this PR to be backported to 2.3, but no objection either. |
I've actually been wondering about a few of the errors on 2.3 (see #59513 (comment)) and this appears to address some of them, so I think it will be required (thanks @bnavigator for investigating!) |
cc @lithomas1 |
I think this fixes the failures, so going to merge on red. thanks @bnavigator |
Backport #59144
remove core.computation.ops.Div resolves pd.eval() discards imaginary part in division "/" #21374 BUG: eval fails for ExtensionArray #58748
need to preserve order
updating tests
update whatsnew// no whatsnew for 2.2.x and 2.3 yetsolve mypy issue
fixing pytests
better than cast
adding specific test
Update pandas/tests/frame/test_query_eval.py// Not backported, fails on 2.2Update pandas/tests/computation/test_eval.py
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature. -- no one found for 2.x