-
-
Notifications
You must be signed in to change notification settings - Fork 18.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #47101 #59492
Fix issue #47101 #59492
Conversation
Bisecting two years ago ( pandas-dev#47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then. PR pandas-dev#48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted.
https://results.pre-commit.ci/run/github/858127/1723498369.6V12SWx7T-WpLZDAXXkz0Q This web UI commit will still fail, as the E501 line-too-long check will fail until the next commit
I honestly don't understand what failed here
|
np.equal([1,2,3], "") fails
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
Reopened as #59766 @mroeschke |
Bisecting two years ago ( #47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then.
PR #48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted.
Patch takes two tracks -- it first replaces the
arr == x
withnp.equals()
which will handle broadcasting in most cases by itself. For the remainder of cases, an explicit type check is done to return an array for the mask.doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.