Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #47101 #59492

Closed
wants to merge 10 commits into from
Closed

Fix issue #47101 #59492

wants to merge 10 commits into from

Conversation

tigerhawkvok
Copy link

@tigerhawkvok tigerhawkvok commented Aug 12, 2024

Bisecting two years ago ( #47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then.

PR #48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted.

Patch takes two tracks -- it first replaces the arr == x with np.equals() which will handle broadcasting in most cases by itself. For the remainder of cases, an explicit type check is done to return an array for the mask.

Bisecting two years ago ( pandas-dev#47101 (comment) ) shows this regression was introduced in b2d54d9 in 2021. Somehow this hasn't been patched since then.

PR pandas-dev#48313 was supposed to address this, but the PR was closed and never merged and the bug has persisted.
@rhshadrach rhshadrach added Bug Constructors Series/DataFrame/Index/pd.array Constructors labels Aug 12, 2024
@tigerhawkvok
Copy link
Author

I honestly don't understand what failed here

ruff-format.............................................................................................Failed
- hook id: ruff-format
- files were modified by this hook

@mroeschke
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

@mroeschke mroeschke closed this Sep 9, 2024
@tigerhawkvok tigerhawkvok mentioned this pull request Sep 9, 2024
5 tasks
@tigerhawkvok
Copy link
Author

tigerhawkvok commented Sep 9, 2024

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

Reopened as #59766 @mroeschke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Constructors Series/DataFrame/Index/pd.array Constructors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: AttributeError: 'bool' object has no attribute 'to_numpy' in "mask_missing" method of core/missing.py
3 participants