Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: lowercase strings w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes #58998

Merged
merged 10 commits into from
Jul 5, 2024
Merged

DEPR: lowercase strings w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes #58998

merged 10 commits into from
Jul 5, 2024

Conversation

natmokval
Copy link
Contributor

@natmokval natmokval commented Jun 13, 2024 •
edited
Loading

xref #57986

  • deprecated lowercase strings d, b and c denoting frequencies in Day, BusinessDay and CustomBusinessDay in favour of D, B and C
  • deprecated lowercase strings w, w-mon, w-tue, etc. denoting frequencies in Week in favour of W, W-MON, W-TUE, etc.

we can deprecated lowercase strings w, d, b and c for Timedelta in a separate PR

@natmokval natmokval changed the title DEPR: deprecate lowercase aliases 'd' for 'Day' DEPR: lowercase strings w, d, b and c denoting frequencies in Week, Day, BusinessDay and CustomBusinessDay classes Jun 14, 2024
@natmokval natmokval added Deprecate Functionality to remove in pandas Frequency DateOffsets labels Jun 14, 2024
@natmokval
Copy link
Contributor Author

I deprecated lowercase strings w, d, b and c denoting frequencies in favour of W, D, B and C. @MarcoGorelli, could you please take a look at this PR? I think CI failures are unrelated to my changes.

@natmokval natmokval marked this pull request as ready for review June 14, 2024 18:34
@natmokval natmokval requested a review from MarcoGorelli as a code owner June 14, 2024 18:34
@natmokval natmokval mentioned this pull request Jun 19, 2024
Merged
MarcoGorelli
MarcoGorelli reviewed Jun 26, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Given that 2.3 isn't out yet, I wonder if it makes sense to get this in for 2.3, and then in 3.0 we make all these changes in one go and be done with it?

@MarcoGorelli
Copy link
Member

@mroeschke thoughts on 2.3 vs 3.0?

@natmokval natmokval mentioned this pull request Jun 27, 2024
Closed
MarcoGorelli
MarcoGorelli approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in doubt, let's just follow the usual process - deprecate in 3.0, remove thereafter - will merge then if there's no further objections

@mroeschke mroeschke added this to the 3.0 milestone Jul 5, 2024
@mroeschke mroeschke merged commit 039edee into pandas-dev:main Jul 5, 2024
45 checks passed
@mroeschke
Copy link
Member

Thanks @natmokval and @MarcoGorelli

@github-actions github-actions bot mentioned this pull request Jul 5, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Frequency DateOffsets
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@natmokval @MarcoGorelli @mroeschke