Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dep groupby corrwith #58732

Merged
merged 11 commits into from
Jun 3, 2024
Merged

Dep groupby corrwith #58732

merged 11 commits into from
Jun 3, 2024

Conversation

pedrocariellof
Copy link
Contributor

rhshadrach
rhshadrach requested changes May 15, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks pretty good, a few requests below.

doc/source/development/policies.rst Outdated Show resolved Hide resolved
doc/source/getting_started/install.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
pandas/tests/groupby/test_all_methods.py Outdated Show resolved Hide resolved
pandas/tests/groupby/test_all_methods.py Outdated Show resolved Hide resolved
pandas/core/groupby/generic.py Show resolved Hide resolved
@rhshadrach rhshadrach added Groupby Deprecate Functionality to remove in pandas labels May 15, 2024
@pedrocariellof pedrocariellof requested a review from rhshadrach May 27, 2024 15:22
@pedrocariellof
Copy link
Contributor Author

@rhshadrach

rhshadrach
rhshadrach requested changes May 29, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, a few minor requests.

doc/source/getting_started/install.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
doc/source/whatsnew/v3.0.0.rst Outdated Show resolved Hide resolved
@pedrocariellof pedrocariellof requested a review from rhshadrach June 1, 2024 02:10
rhshadrach
rhshadrach requested changes Jun 3, 2024
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added this to the 3.0 milestone Jun 3, 2024
@rhshadrach rhshadrach merged commit 76c7274 into pandas-dev:main Jun 3, 2024
47 checks passed
@rhshadrach
Copy link
Member

Thanks @pedrocariellof - and for the additional cleanups too!

@github-actions github-actions bot mentioned this pull request Jun 3, 2024
Open
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@noatamir noatamir Awaiting requested review from noatamir

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Groupby
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

DEPR: groupby.corrwith
3 participants
@pedrocariellof @rhshadrach @tomytp