CLN: Stopped casting values in Series/Index.isin for datelike dtypes #58645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
commented
May 8, 2024
pandas/core/arrays/datetimelike.py
Outdated
| try: | ||
| values = type(self)._from_sequence(values) | ||
| except ValueError: | ||
| if "mixed" in lib.infer_dtype(values, skipna=False): |
There was a problem hiding this comment.
@jbrockmendel did you intend to allow the mixed object case? pandas/tests/indexes/test_datetimelike.py::TestDatetimeLike::test_isin
There was a problem hiding this comment.
id be OK with deprecating that, but didn't have that in mind with the deprecation here. the deprecation here was aimed at avoiding a try/except on _from_sequence.
There was a problem hiding this comment.
i also suspect we can avoid the "mixed" check and just check for object dtype.
There was a problem hiding this comment.
Cool. I added a comment to deprecate in the future.
Also nice find. I was able to avoid the infer_dtype call
WillAyd
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #53111