Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fixing SA01 errors for index.size, shape, and ndim. #58333

Merged
merged 4 commits into from
Apr 20, 2024

Conversation

KeiOshima
Copy link
Contributor

@KeiOshima KeiOshima commented Apr 20, 2024

@KeiOshima KeiOshima requested a review from mroeschke as a code owner April 20, 2024 02:06
@@ -355,6 +355,13 @@ def ndim(self) -> Literal[1]:
"""
Number of dimensions of the underlying data, by definition 1.

See Also
--------
Index.size: Return the number of elements in the underlying data.
Copy link
Member

@mroeschke mroeschke Apr 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this file, could you reference Series instead of Index?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

@mroeschke mroeschke added the Docs label Apr 20, 2024
@KeiOshima KeiOshima requested a review from mroeschke April 20, 2024 19:04
@mroeschke mroeschke added this to the 3.0 milestone Apr 20, 2024
@mroeschke mroeschke merged commit 7cafc21 into pandas-dev:main Apr 20, 2024
46 checks passed
@mroeschke
Copy link
Member

Thanks @KeiOshima

@KeiOshima KeiOshima deleted the doc-pandas-Index-size branch April 20, 2024 19:19
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…58333)

* Doc: fixing SA01 for index.size, shape, and ndim

* EXPECTED TO FAIL, BUT NOT FAILING

* changing from Index to Series for core/basy.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants