CLN: enforce deprecation of the Series[categorical].replace special-casing #58270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natmokval
changed the title
pandas/core/arrays/categorical.py
Outdated
| @@ -2680,15 +2680,9 @@ def _replace(self, *, to_replace, value, inplace: bool = False) -> Self | None: | |||
| NDArrayBacked.__init__(cat, new_codes, new_dtype) | |||
|
|
|||
| if new_dtype != orig_dtype: | |||
| warnings.warn( | |||
| # GH#55147 | |||
| raise TypeError( | |||
There was a problem hiding this comment.
is this method called anywhere? i think it can just be removed
There was a problem hiding this comment.
there is special-casing in internals.blocks that calls this method. that special-casing needs to be removed
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
…freplace-sreplace-with-CategoricalDtype
mroeschke
approved these changes
Jun 25, 2024
|
Thanks for starting this @natmokval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #56385
enforced deprecation of the behavior of
DataFrame.replaceandSeries.replacewithCategoricalDtype