-
-
Notifications
You must be signed in to change notification settings - Fork 18.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: correct error msg in test_view_index
#58181
CI: correct error msg in test_view_index
#58181
Conversation
@@ -312,7 +312,7 @@ def test_cant_or_shouldnt_cast(self, dtype): | |||
|
|||
def test_view_index(self, simple_index): | |||
index = simple_index | |||
msg = "Cannot change data-type for object array" | |||
msg = "Cannot change data-type for array of references." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to support both error messages probably as the error messages only changed on the dev build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I added the previous error message to the new one.
Thanks for the quick fix! |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
@natmokval mind doing the backport? |
sure, I'll do the backport |
* correct error msg in test_view_index * correct err msg
CI failed, the reason:
AssertionError: Regex pattern did not match.
Replaced error msg
'Cannot change data-type for object array'
with'Cannot change data-type for array of references.'