REGR: from_records not initializing subclasses properly #58145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
the
Regression
jbrockmendel
reviewed
Apr 4, 2024
| @@ -2302,7 +2302,8 @@ def maybe_reorder( | |||
| columns = columns.drop(exclude) | |||
|
|
|||
| mgr = arrays_to_mgr(arrays, columns, result_index) | |||
| return cls._from_mgr(mgr, axes=mgr.axes) | |||
| result = cls._from_mgr(mgr, axes=mgr.axes) | |||
There was a problem hiding this comment.
df = DataFrame._from_mgr(...)
if cls is not DataFrame:
return cls(df, copy=False)
return df
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
Closing to clear the queue, but feel free to update and reopen anytime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel would appreciate thoughts, we don't have access to _constructor_from_mgr, so we need a workaround somehow.