CLN: remove unnecessary check needs_i8_conversion if Index subclass does not support any or all

pandas/core/indexes/base.py

@@ -179,7 +179,6 @@
 )
 from pandas.core.missing import clean_reindex_fill_method
 from pandas.core.ops import get_op_result_name
-from pandas.core.ops.invalid import make_invalid_op
 from pandas.core.sorting import (
     ensure_key_mapped,
     get_group_index_sorter,
@@ -6960,14 +6959,8 @@ def _maybe_disable_logical_methods(self, opname: str_t) -> None:
         """
         raise if this Index subclass does not support any or all.
         """
-        if (
-            isinstance(self, ABCMultiIndex)
-            # TODO(3.0): PeriodArray and DatetimeArray any/all will raise,
-            #  so checking needs_i8_conversion will be unnecessary
-            or (needs_i8_conversion(self.dtype) and self.dtype.kind != "m")
-        ):
-            # This call will raise
-            make_invalid_op(opname)(self)
+        if isinstance(self, ABCMultiIndex):
+            raise TypeError(f"cannot perform {opname} with {type(self).__name__}")
 
     @Appender(IndexOpsMixin.argmin.__doc__)
     def argmin(self, axis=None, skipna: bool = True, *args, **kwargs) -> int:

pandas/tests/indexes/test_old_base.py

@@ -216,7 +216,12 @@ def test_logical_compat(self, simple_index):
         if simple_index.dtype in (object, "string"):
             pytest.skip("Tested elsewhere.")
         idx = simple_index
-        if idx.dtype.kind in "iufcbm":
+
+        if isinstance(idx, DatetimeIndex):
+            msg = "'(any|all)' with datetime64 dtypes is deprecated"
+            with tm.assert_produces_warning(FutureWarning, match=msg):
+                idx.all()
+        elif idx.dtype.kind in "iufcbm":
             assert idx.all() == idx._values.all()
             assert idx.all() == idx.to_series().all()
             assert idx.any() == idx._values.any()
@@ -228,6 +233,8 @@ def test_logical_compat(self, simple_index):
                     r"'IntervalArray' with dtype interval\[.*\] does "
                     "not support reduction '(any|all)'"
                 )
+            if isinstance(idx, PeriodIndex):
+                msg = "does not support reduction '(any|all)'"
             with pytest.raises(TypeError, match=msg):
                 idx.all()
             with pytest.raises(TypeError, match=msg):