-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: remove unnecessary check needs_i8_conversion
if Index subclass does not support any
or all
#58006
Merged
mroeschke
merged 14 commits into
pandas-dev:main
from
natmokval:remove-unnecessary-check-needs_i8_conversion
Apr 4, 2024
Merged
CLN: remove unnecessary check needs_i8_conversion
if Index subclass does not support any
or all
#58006
Changes from 10 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c3cf9a1
cln-remove-unnecessary-check-needs_i8_conversion
natmokval 54983c5
fix tests
natmokval 3b2242f
remove the check self.dtype.kind, fix tests
natmokval c253533
Update pandas/core/indexes/base.py
natmokval 923aa2f
Merge branch 'main' into remove-unnecessary-check-needs_i8_conversion
natmokval 0b71ac1
combine two branches in test_logical_compat
natmokval 01ce724
Merge branch 'main' into remove-unnecessary-check-needs_i8_conversion
natmokval add58c0
correct test_logical_compat
natmokval be3ab97
Merge branch 'remove-unnecessary-check-needs_i8_conversion' of https:…
natmokval 18fab28
correct test_logical_compat
natmokval c887a85
correct test_logical_compat
natmokval bac52c5
roll back the check for datetime64 in test_logical_compat
natmokval 6efebb8
replace reduction with operation to unify err msg
natmokval 4ff9cea
delete unused line
natmokval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -223,11 +223,10 @@ def test_logical_compat(self, simple_index): | |
assert idx.any() == idx.to_series().any() | ||
else: | ||
msg = "cannot perform (any|all)" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. L225 looks like it can be safely deleted |
||
if isinstance(idx, IntervalIndex): | ||
msg = ( | ||
r"'IntervalArray' with dtype interval\[.*\] does " | ||
"not support reduction '(any|all)'" | ||
) | ||
if isinstance(idx, DatetimeIndex): | ||
msg = "datetime64 type does not support operation: '(any|all)'" | ||
else: | ||
msg = "does not support reduction '(any|all)'" | ||
with pytest.raises(TypeError, match=msg): | ||
idx.all() | ||
with pytest.raises(TypeError, match=msg): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can delete L225-L228? i.e. the only thing needed here to pass tests is
msg = "does not support reduction '(any|all)'"
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, I deleted the branch with
msg = "datetime64 type does not support operation: '(any|all)'"
, ci- green.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh OK I see the issue now. So you are branching because DatetimeIndex says
does not support operation: '(any|all)'
but the other cases say'does not support reduction '(any|all)'
I don't want to go down a rabbit hole but having a message that differs between operation: and reduction doesn't seem that important. How hard is it to align them so you can just assign
msg = "does not support operation: '(any|all)'
and have the tests pass?