BUG: #57954 encoding ignored for filelike #57968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…like' into #57954_encoding_ignored_for_filelike
…ored_for_filelike
dontgoto
changed the title
mroeschke
reviewed
Mar 25, 2024
pandas/io/parsers/readers.py
Outdated
| @@ -1485,6 +1485,17 @@ def _make_engine( | |||
| "pyarrow": ArrowParserWrapper, | |||
| "python-fwf": FixedWidthFieldParser, | |||
| } | |||
|
|
|||
| file_encoding = getattr(f, "encoding", None) | |||
There was a problem hiding this comment.
This check might be better in _check_file_or_buffer
There was a problem hiding this comment.
I like your suggestion, but trying that out the type checking throws errors. None of the annotated classes in _make_engine guarantee an encoding attribute, so the getattr check would be necessary here anyway at least for the type checker.
There was a problem hiding this comment.
It's OK adding typing ignores as needed
mroeschke
added
Error Reporting
mroeschke
approved these changes
Mar 28, 2024
|
Thanks @dontgoto |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* add exception when encodings exist and do not match * add exception when encodings exist and do not match * add test for mismatching encodings warning * add test for mismatching encodings warning * add encoding for python 3.10+ * move to _check_file; invert var and condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_csvon FileLike objects #57954