DEPR: remove deprecated freqs/abbrevs 'A', 'A-DEC', 'A-JAN', etc. #57699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
reviewed
Mar 1, 2024
pandas/_libs/tslibs/dtypes.pxd
Outdated
| @@ -18,6 +18,7 @@ cdef dict c_DEPR_ABBREVS | |||
| cdef dict attrname_to_abbrevs | |||
| cdef dict npy_unit_to_attrname | |||
| cdef dict attrname_to_npy_unit | |||
| cdef set c_REMOVED_ABBREVS | |||
There was a problem hiding this comment.
I don't think we need to keep track of these over time. Should just be able to remove from c_DEPR_ABBREVS and call it a day I think
MarcoGorelli
reviewed
Mar 7, 2024
Comment on lines
285
to
299
| @pytest.mark.parametrize( | ||
| "freq, freq_depr", | ||
| [ | ||
| ("1YE", "1A"), | ||
| ("2YE-MAR", "2A-MAR"), | ||
| ], | ||
| ) | ||
| def test_asfreq_frequency_A_raisees(self, freq, freq_depr): | ||
| msg = f"Invalid frequency: {freq_depr[1:]}" | ||
|
|
||
| index = date_range("1/1/2000", periods=4, freq=f"{freq[1:]}") | ||
| df = DataFrame({"s": Series([0.0, 1.0, 2.0, 3.0], index=index)}) | ||
|
|
||
| with pytest.raises(ValueError, match=msg): | ||
| df.asfreq(freq=freq_depr) |
There was a problem hiding this comment.
it's not clear to me what you're doing with freq in this test - I think index can just be instatiated with 'YE' in both cases?
There was a problem hiding this comment.
I think, in the first case we get df.index.freqstr = YE-DEC, and in second case df.index.freqstr =YE-MAR
There was a problem hiding this comment.
yes, you are right, it's sufficient to check only freq="A". I simplified the test and added a note to v3.0.0.
Could you please take a look at my changes?
MarcoGorelli
approved these changes
Mar 8, 2024
|
Thanks @MarcoGorelli for reviewing this PR. |
WillAyd
approved these changes
Mar 8, 2024
|
Thanks @natmokval |
23 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #55252
remove deprecated string 'A', 'A-DEC', etc. denoting timedelta abbreviations and timeseries frequencies