Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: fix PR01/SA01 errors for pandas.tseries.offsets.*.is_(month|quarter|year)_(end|start) #57630

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

yuanx749
Copy link
Contributor

@yuanx749 yuanx749 commented Feb 26, 2024

@yuanx749
Copy link
Contributor Author

/preview

Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/57630/

@yuanx749 yuanx749 marked this pull request as ready for review February 27, 2024 03:48
Comment on lines -29 to -30
DateOffset.is_month_start
DateOffset.is_month_end
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When browsing the preview, I notice these two methods are placed in both Properties and Methods sections.
Seems to be a mistake, so remove them here.

@yuanx749 yuanx749 changed the title DOC: fix PR01 errors for pandas.tseries.offsets.*.is_*_end/start DOC: fix PR01/SA01 errors for pandas.tseries.offsets.*.is_(month|quarter|year)_(end|start) Feb 27, 2024
@datapythonista
Copy link
Member

/preview

@datapythonista datapythonista added Docs Datetime Datetime data dtype labels Feb 27, 2024
Copy link
Contributor

Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/57630/

Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR @yuanx749, thanks a lot for working on this.

@mroeschke mroeschke added this to the 3.0 milestone Feb 27, 2024
@mroeschke mroeschke merged commit a73ab97 into pandas-dev:main Feb 27, 2024
53 checks passed
@mroeschke
Copy link
Member

Thanks @yuanx749

@yuanx749 yuanx749 deleted the doc/offset branch February 28, 2024 04:34
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
…ter|year)_(end|start) (pandas-dev#57630)

* Doc: fix PR01 errors for pandas.tseries.offsets.*.is_*_end/start

* Clean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Datetime Datetime data dtype Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants