Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: resolve GL08 for pandas.core.groupby.SeriesGroupBy.value_counts #57609

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

jordan-d-murphy
Copy link
Contributor

All GL08 Errors resolved in the following cases:

  1. scripts/validate_docstrings.py --format=actions --errors=GL08 pandas.core.groupby.SeriesGroupBy.value_counts

@jordan-d-murphy
Copy link
Contributor Author

pre-commit.ci autofix

pandas/core/groupby/generic.py Outdated Show resolved Hide resolved
pandas/core/groupby/generic.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@jordan-d-murphy jordan-d-murphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated as_index to ``as_index``

pandas/core/groupby/generic.py Outdated Show resolved Hide resolved
pandas/core/groupby/generic.py Outdated Show resolved Hide resolved
@jordan-d-murphy
Copy link
Contributor Author

updated this PR based on your feedback, @rhshadrach can you take another look?

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Docs Groupby CI Continuous Integration labels Feb 26, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Feb 26, 2024
@rhshadrach rhshadrach merged commit f1a78d5 into pandas-dev:main Feb 26, 2024
55 checks passed
@rhshadrach
Copy link
Member

Thanks @jordan-d-murphy

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Docs Groupby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants