CoW: Deprecate copy keyword from first set of methods #57347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/core/generic.py
mroeschke
reviewed
Feb 24, 2024
| "version. Copy-on-Write is active in pandas since 3.0 which utilizes " | ||
| "a lazy copy mechanism that defers copies until necessary. Use " | ||
| ".copy() to make an eager copy if necessary.", | ||
| DeprecationWarning, |
There was a problem hiding this comment.
DeprecationWarning because we're going to start following DeprecationWarning -> FutureWarning?
There was a problem hiding this comment.
Yep, my intention was to switch to FutureWarning in 3.2, but I suspect that copy=False is used by a lot of downstream libraries
mroeschke
approved these changes
Feb 24, 2024
|
Thanks @phofl |
23 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* CoW: Remove a few copy=False statements * Cow: Deprecate copy keyword from first set of methods * Fixup * Update * Update * Update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.