DEPR: removed deprecated argument obj from GroupBy get_group
#57136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcoGorelli, could you please take a look at this PR? CI failures aren't related to my changes. |
WillAyd
reviewed
Jan 30, 2024
pandas/core/groupby/groupby.py
Outdated
| stacklevel=find_stack_level(), | ||
| ) | ||
| return obj._take_with_is_copy(inds, axis=self.axis) | ||
| raise ValueError("cannot pass argument obj to get_group") |
There was a problem hiding this comment.
Sorry if I missed any conversations on this but I am fairly certain you can just remove the obj=None parameter from the function definition and then remove this if...else block altogether
There was a problem hiding this comment.
thank you, I removed the parameter obj from the definition of get_group, the block if...else and corrected docstring.
rhshadrach
requested changes
Jan 30, 2024
doc/source/whatsnew/v3.0.0.rst
Outdated
|
|
||
| Removal of prior version deprecations/changes | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| - Removed deprecated argument ``obj`` in :meth:`GroupBy.get_group` (:issue:`53545`) |
There was a problem hiding this comment.
In order to resolve a link to the documentation, can you replace the end with
:meth:`.DataFrameGroupBy.get_group` and :meth:`.SeriesGroupBy.get_group`
There was a problem hiding this comment.
thank you, I corrected the note in v3.0.0.rst
WillAyd
approved these changes
Jan 31, 2024
23 tasks
|
Thanks @natmokval! |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objfrom GroupByget_group