DEPR: Enforce deprecation of removing axis from all groupby ops #57109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pandas/tests/groupby/test_reductions.py
…h/pandas into enf_groupby_axis_1_ops
rhshadrach
commented
Jan 30, 2024
| @@ -181,6 +181,7 @@ if [[ -z "$CHECK" || "$CHECK" == "docstrings" ]]; then | |||
| pandas.core.groupby.SeriesGroupBy.rolling\ | |||
| pandas.core.groupby.DataFrameGroupBy.hist\ | |||
| pandas.core.groupby.DataFrameGroupBy.plot\ | |||
| pandas.core.groupby.DataFrameGroupBy.corrwith\ | |||
There was a problem hiding this comment.
I was going to add groupby-specific documentation to this method (rather than just repeating the DataFrame version), but the more I look at it, the more I think we should just deprecate this method. Will make an issue.
# Conflicts: # doc/source/whatsnew/v3.0.0.rst
mroeschke
reviewed
Jan 31, 2024
| # a little trickery for aggregation functions that need an axis | ||
| # argument | ||
| if "axis" in sig.parameters: | ||
| if kwargs.get("axis", None) is None or kwargs.get("axis") is lib.no_default: | ||
| kwargs["axis"] = self.axis | ||
| kwargs["axis"] = self.axis |
There was a problem hiding this comment.
Will this be able to be removed once we remove axis from groupby?
There was a problem hiding this comment.
Yep! That's coming next.
mroeschke
approved these changes
Jan 31, 2024
|
Thanks @rhshadrach |
23 tasks
5 tasks
5 tasks
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…as-dev#57109) * DEPR: Enforce deprecation of removing axis from all groupby ops * Add note on fillna and cleanup * Doc fixups * Remove corrwith axis=1 test * Remove corrwith axis=1 test * Skip corrwith docstring validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.