BUG: Series.to_numpy raising for arrow floats to numpy floats #56644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 27, 2023
| @@ -1320,6 +1321,7 @@ def to_numpy( | |||
| copy: bool = False, | |||
| na_value: object = lib.no_default, | |||
| ) -> np.ndarray: | |||
| original_na_value = na_value | |||
There was a problem hiding this comment.
Just wondering, shouldn't this case be handled in to_numpy_dtype_inference?
There was a problem hiding this comment.
The scope of the function is if no dtype is given, we can extend this, but I don’t know if that’s a good idea
mroeschke
approved these changes
Dec 28, 2023
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Dec 28, 2023
…floats to numpy floats
3 tasks
mroeschke
pushed a commit
that referenced
this pull request
Dec 28, 2023
…arrow floats to numpy floats) (#56648) Backport PR #56644: BUG: Series.to_numpy raising for arrow floats to numpy floats Co-authored-by: Patrick Hoefler <[email protected]>
cbpygit
pushed a commit
to cbpygit/pandas
that referenced
this pull request
Jan 2, 2024
…-dev#56644) * BUG: Series.to_numpy raising for arrow floats to numpy floats * Fixup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.interpolate()Method Incompatible withfloat[pyarrow]Dtype #56267 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.