Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: delim_whitespace kwd in read_csv #56557

Merged
merged 6 commits into from
Dec 21, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

FutureWarning, match=depr_msg, check_stacklevel=False
):
parser.read_csv(
StringIO(data), delim_whitespace=True, usecols=("a", "b")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can most of these be replaced with sep=r"\s+" instead already?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think that will introduce a bunch of duplicate tests, this way we can remove these entirely once the deprecation is enforced

@mroeschke mroeschke added IO CSV read_csv, to_csv Deprecate Functionality to remove in pandas labels Dec 19, 2023
@mroeschke mroeschke added this to the 2.2 milestone Dec 21, 2023
@mroeschke mroeschke merged commit 4ac340e into pandas-dev:main Dec 21, 2023
44 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-csv-kwargs branch December 21, 2023 15:29
cbpygit pushed a commit to cbpygit/pandas that referenced this pull request Jan 2, 2024
* DEPR: delim_whitespace kwd in read_csv

* Update doc/source/whatsnew/v2.2.0.rst

Co-authored-by: Matthew Roeschke <[email protected]>

---------

Co-authored-by: Matthew Roeschke <[email protected]>
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Feb 13, 2024
Toward pandas 2.2 compat: Deprecated in pandas in pandas-dev/pandas#56557

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - Ashwin Srinath (https://github.com/shwina)

URL: #14986
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants