TST: Added a test for groupby.prod #56384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccccjone
changed the title
3 tasks
phofl
reviewed
Dec 8, 2023
rhshadrach
requested changes
Dec 9, 2023
| [1, multiplier], | ||
| ] | ||
| df = DataFrame(data, columns=["A", "B"]) | ||
| df_prod = DataFrame([df.prod()], columns=df.columns) |
There was a problem hiding this comment.
Can you hardcode this instead (assuming the parametrization will be removed)
There was a problem hiding this comment.
By "hardcode", I mean something like expected = DataFrame([[12345], [6789]], columns["B"]). In other words, don't use df.prod().
There was a problem hiding this comment.
@rhshadrach Sorry for the misunderstanding. I have now updated the code based on your explanation. Could you please take a look and let me know if this is now correct, or if there are any further modifications needed? Thanks for your kind assistance.
|
Hi @rhshadrach , thank you for your review and suggestions. I have updated the code based on your feedback. Please review. Appreciate your help and guidance! |
rhshadrach
added
Bug
Groupby
Reduction Operations
|
Thanks @ccccjone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes BUG: prod and groupby.prod behave differently #46573
The bug related to issue BUG: prod and groupby.prod behave differently #46573 has been fixed in the current version.
Added a test related to this issue. The test is designed to check if
groupby.prodreturns the same results asprod.