Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS: remove duplicated dependency in requirement-dev.txt #55101

Merged
merged 6 commits into from
Sep 13, 2023

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Sep 11, 2023

No description provided.

@mroeschke
Copy link
Member

I think this is already tested here essentially?

requirements-dev-text-installable:

@fangchenli
Copy link
Member Author

I think this is already tested here essentially?

requirements-dev-text-installable:

Seems so. Then I wondered why it didn't catch the double requirements given error. I'll remove the CI check and make this PR a simple fix.

@fangchenli fangchenli marked this pull request as ready for review September 13, 2023 19:11
@fangchenli fangchenli added the Dependencies Required and optional dependencies label Sep 13, 2023
@fangchenli fangchenli changed the title Test installing dev dependencies with pip DEPS: remove duplicated dependency in requirement-dev.txt Sep 13, 2023
@mroeschke mroeschke added this to the 2.2 milestone Sep 13, 2023
@mroeschke mroeschke merged commit 81fb7e7 into pandas-dev:main Sep 13, 2023
31 of 33 checks passed
@mroeschke
Copy link
Member

Thanks @fangchenli

hedeershowk pushed a commit to hedeershowk/pandas that referenced this pull request Sep 20, 2023
…#55101)

* Test installing dev dependencies with pip

* fix typo

* remove 3.12, list deps

* remove pip ci test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Required and optional dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants