Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add empty line in no-bool-in-generic to avoid black complaining #54855

Merged
merged 3 commits into from
Aug 31, 2023

Conversation

Charlie-XIAO
Copy link
Contributor

No reference issues (I ran into this during another contribution).

@mroeschke
Copy link
Member

Why is this needed?

@Charlie-XIAO
Copy link
Contributor Author

Charlie-XIAO commented Aug 31, 2023

For instance if I used bool in generic, this hook will delete the last empty line. Then if I add the changes and commit again, black will complain about it. Well then if you add the changes and commit again everything will be fine, but I just think it would be better to avoid such conflict.

Or did I miss something? @mroeschke

@mroeschke
Copy link
Member

Can you show a commit where this happened?

@Charlie-XIAO
Copy link
Contributor Author

Charlie-XIAO commented Aug 31, 2023

Does this suffice? @mroeschke

Windows.PowerShell.2023-08-31.10-02-54.1.mp4

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Aug 31, 2023
@mroeschke mroeschke added this to the 2.2 milestone Aug 31, 2023
@mroeschke mroeschke merged commit 1e482de into pandas-dev:main Aug 31, 2023
@mroeschke
Copy link
Member

Ah great thanks for that demonstration 👍

mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023
…ng (pandas-dev#54855)

* black will complain if there is no additional empty line

* also update the test
@Charlie-XIAO Charlie-XIAO deleted the precommit-nobool-lastl branch September 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants