DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs #54061

natmokval · 2023-07-10T08:40:33Z

deprecated codes 'T' and 'L' in _attrname_to_abbrevs/_abbrev_to_attrnames, added a test for FutureWarning.

EDIT:

Deprecated in Timedelta units 'T', 'L', 'U', 'N' in favour of 'min', 'ms', 'us', 'ns'.
Deprecated aliases 'T', 'L', 'U', 'N' for time series frequencies in favour of 'min', 'ms', 'us', 'ns'.
Deprecated resolutions 'T', 'L', 'U', 'N' for Timedelta.resolution_string in favour of 'min', 'ms', 'us', 'ns'.

natmokval · 2023-07-10T23:16:27Z

@jbrockmendel, could you please take a look at my pr? I started deprecating codes “T” and “L” in _attrname_to_abbrevs/_abbrev_to_attrnames and I got an issue. Could you please help me with this?

First, If we deprecate “T” and “L”, we should replace them with new abbreviations. I don't know that we can use instead of “T” and “L”. Can we use one of the abbreviations, which we have for minutes and milliseconds, e.g.: min and ms?

And another question: in class Minute(Tick) and class Milli(Tick) we use “T” and “L” as a _prefix. As I understand we deprecate them as well and we replace them with the new abbreviations for minutes and milliseconds. Am I correct?

jbrockmendel · 2023-07-11T19:21:45Z

First, If we deprecate “T” and “L”, we should replace them with new abbreviations. I don't know that we can use instead of “T” and “L”. Can we use one of the abbreviations, which we have for minutes and milliseconds, e.g.: min and ms?

And another question: in class Minute(Tick) and class Milli(Tick) we use “T” and “L” as a _prefix. As I understand we deprecate them as well and we replace them with the new abbreviations for minutes and milliseconds. Am I correct?

Yes and yes.

…revs and fix tests

…fix tests

pandas/core/arrays/arrow/array.py

…brev_to_attrnames

…ffset_to_period_map and fix tests

…brev_to_attrnames

natmokval · 2023-07-26T11:27:30Z

Hi @jbrockmendel. I have a question. Should we deprecate 'A' for 'year' as well? We can left 'Y' as an alias for 'year'.

My qustion is related to PR: DEPR offsets: rename ‘M’ to ‘ME’ #52064. I started deprecating for offsets 'A' in favour of 'AE' and I can do either:

rename A to AE and Y to YE
deprecate A/AE in favour of Y/YE

…brev_to_attrnames

MarcoGorelli

Nice, getting close! Looks like there's just some doctest failures, and some asv ones

Also this is in the docs build

RuntimeError: Non Expected exception in /home/runner/work/pandas/pandas/doc/source/user_guide/scale.rst line None

so there may be something in that file too

MarcoGorelli

Nice!

Have left some comments (which maybe you were going to address anyway 🙈 either way, thought I'd leave them in case)

pandas/_libs/tslibs/dtypes.pyx

pandas/core/dtypes/dtypes.py

pandas/_libs/tslibs/dtypes.pyi

pandas/core/tools/timedeltas.py

pandas/tests/indexes/timedeltas/test_timedelta_range.py

pandas/tests/scalar/period/test_asfreq.py

pandas/tests/scalar/timedelta/test_timedelta.py

pandas/tests/tseries/frequencies/test_freq_code.py

…brev_to_attrnames

natmokval · 2023-08-18T12:45:42Z

@MarcoGorelli, @jbrockmendel, could you please take a look at my changes? I corrected the pr as you suggested. Seems like failures in ci aren't related to my changes.

MarcoGorelli

generally looks good, just got some minor comments

I think we should do hours as well, but please keep that to a separate PR

MarcoGorelli · 2023-08-22T10:50:55Z

doc/source/user_guide/timeseries.rst

@@ -905,11 +905,11 @@ into ``freq`` keyword arguments. The available date offsets and associated frequ
    :class:`~pandas.tseries.offsets.CustomBusinessHour`, ``'CBH'``, "custom business hour"
    :class:`~pandas.tseries.offsets.Day`, ``'D'``, "one absolute day"
    :class:`~pandas.tseries.offsets.Hour`, ``'H'``, "one hour"


This doesn't need changing in this PR (can be done as a follow-up, there's plenty of time until pandas 2.2), but if we're doing these renamings, then 'H' should probably be renamed too (and CBH, and BH)

I'd stop there - then there a simple rule: anything sub-daily is lowercase, anything daily or higher is upper-case

Thank you for the comments. I agree, it would be better to rename 'H', 'CBH', and 'BH' too, I'll do it in a separate PR. I like the idea to keep anything sub-daily lowercase, and daily or higher upper-case.

doc/source/whatsnew/v2.2.0.rst

pandas/_libs/tslibs/offsets.pyx

pandas/tests/frame/methods/test_asof.py

MarcoGorelli

Looks really good to me, fantastic work here! Sorry it's taken a while to review. I think this should go in

Leaving open a bit in case anyone has objections, but then will merge

natmokval · 2023-08-25T13:03:59Z

Looks really good to me, fantastic work here! Sorry it's taken a while to review. I think this should go in

Leaving open a bit in case anyone has objections, but then will merge

Thank you for helping me with this PR.
Cats are amazing :)

MarcoGorelli · 2023-08-29T15:10:33Z

Right, let's do this, thanks @natmokval

…olution abbreviations, _attrname_to_abbrevs (pandas-dev#54061)

DEPR: deprecate codes T and L in to_abbrevs/_abbrev_to_attrnames

6e3e96e

mroeschke added the Deprecate Functionality to remove in pandas label Jul 11, 2023

natmokval added 4 commits July 12, 2023 18:08

replace T/L with min/ms in _prefix, period_code_map, _attrname_to_abb…

fe88663

…revs and fix tests

correct def get_freq for tseries, fix tests

1e79480

replace T, L in _offset_to_period_map, is_subperiod, is_superperiod, …

f7fd2a1

…fix tests

correct def to_timedelta, def _round_temporally and fix tests

98e8a39

jbrockmendel reviewed Jul 18, 2023

View reviewed changes

pandas/core/arrays/arrow/array.py Outdated Show resolved Hide resolved

natmokval added 8 commits July 21, 2023 10:42

correct def resolution_string, get_reso_from_freqstr and fix tests

93bbd08

Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…

b0dfd2f

…brev_to_attrnames

fix tests

51c62a1

correct def _maybe_coerce_freq , is_subperiod, is_superperiod, and _o…

898f811

…ffset_to_period_map and fix tests

fix a test for plotting

1d30c07

Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…

37de346

…brev_to_attrnames

fix tests

7171237

fix failures in asv benchmarks

29dcd8d

correct docstrings

317718a

natmokval mentioned this pull request Jul 27, 2023

DEPR: deprecate the alias 'A' in favour of 'Y' for year end frequency #54275

Closed

natmokval added 4 commits July 31, 2023 09:48

deprecate abbrevs U, N add dict depr_abbrevs and fix tests

99a0cf9

correct get_freq and fix tests

a13a041

Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…

a949282

…brev_to_attrnames

correct is_superperiod, is_subperiod, _maybe_coerce_freq and fix tests

7bd6188

MarcoGorelli changed the title ~~DEPR: deprecate codes T and L in _attrname_to_abbrevs/_abbrev_to_attrnames~~ DEPR: deprecate codes T, L, N, and U in _attrname_to_abbrevs/_abbrev_to_attrnames Aug 1, 2023

correct __eq__ for PeriodDtype

77949c4

MarcoGorelli reviewed Aug 1, 2023

View reviewed changes

natmokval added 2 commits August 1, 2023 14:26

update docstrings

a24c0ec

correct whatsnew and user_guide

733d68b

MarcoGorelli requested changes Aug 1, 2023

View reviewed changes

natmokval added 5 commits August 17, 2023 19:15

Merge branch 'main' into DEPR-codes-T-L-from-_attrname_to_abbrevs-_ab…

9ba1734

…brev_to_attrnames

correct docs, tests, and add lines to whatsnew/v2.2.0.rst

b79e9b6

resolve conflict

3408d0b

correct examples in docs

12888f8

resolve conflict

cdd5f6b

natmokval changed the title ~~DEPR: deprecate codes T, S, L, U, and N in _attrname_to_abbrevs/_abbrev_to_attrnames~~ DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs Aug 18, 2023

resolve conflict

c7b8b24

MarcoGorelli requested changes Aug 22, 2023

View reviewed changes

natmokval added 4 commits August 22, 2023 15:42

correct v2.2.0.rst and test_subset

5bb2ca8

resolve conflict in v2.2.0.rst

c54e431

resolve conflict

0966d2f

resolve conflict v2.2.0.rst

271bd6b

mroeschke modified the milestones: 2.1, 2.2 Aug 23, 2023

MarcoGorelli approved these changes Aug 25, 2023

View reviewed changes

MarcoGorelli added the Frequency DateOffsets label Aug 29, 2023

MarcoGorelli merged commit b2dcf2e into pandas-dev:main Aug 29, 2023

github-actions bot mentioned this pull request Aug 29, 2023

DEPR: List of deprecations to be removed in 3.0 #50578

Open

natmokval mentioned this pull request Sep 1, 2023

DEPR: deprecate string H, BH, CBH in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs #54939

Merged

mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Sep 11, 2023

DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, res…

866dc08

…olution abbreviations, _attrname_to_abbrevs (pandas-dev#54061)

natmokval mentioned this pull request Sep 22, 2023

DEPR: 'A' for yearly frequency and YearEnd in favour of 'Y' #55252

Merged

spencerkclark mentioned this pull request Oct 31, 2023

Update cftime frequency strings in line with recent updates in pandas pydata/xarray#8394

Closed

natmokval mentioned this pull request Nov 4, 2023

DOC: replace deprecated freqs in user_guide Period #55831

Merged

natmokval mentioned this pull request Dec 11, 2023

DOC: replace deprecated freqs 'T', 'S', 'A' in docs and comments #56464

Merged

natmokval mentioned this pull request Dec 21, 2023

DEPR: lower/uppercase strings such as 'y', 'q', 'H', 'MIN', etc. denoting freqs/units for time series, period, and timedelta #56346

Closed

natmokval mentioned this pull request Feb 25, 2024

DEPR: remove deprecated units ‘H’, ’T’, and smaller from Timedelta, TimedeltaIndex #57627

Merged

MarcoGorelli mentioned this pull request Aug 14, 2024

BUG: Either incorrect unit validation for 'T' in to_timedelta() or incorrect documentation #52536

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs #54061

DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs #54061

natmokval commented Jul 10, 2023 •

edited

Loading

natmokval commented Jul 10, 2023 •

edited

Loading

jbrockmendel commented Jul 11, 2023

natmokval commented Jul 26, 2023

MarcoGorelli left a comment

MarcoGorelli left a comment

natmokval commented Aug 18, 2023

MarcoGorelli left a comment

MarcoGorelli Aug 22, 2023

natmokval Aug 22, 2023

MarcoGorelli left a comment

natmokval commented Aug 25, 2023

MarcoGorelli commented Aug 29, 2023

DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs #54061

DEPR: deprecate strings T, S, L, U, and N in offsets frequencies, resolution abbreviations, _attrname_to_abbrevs #54061

Conversation

natmokval commented Jul 10, 2023 • edited Loading

natmokval commented Jul 10, 2023 • edited Loading

jbrockmendel commented Jul 11, 2023

natmokval commented Jul 26, 2023

MarcoGorelli left a comment

Choose a reason for hiding this comment

MarcoGorelli left a comment

Choose a reason for hiding this comment

natmokval commented Aug 18, 2023

MarcoGorelli left a comment

Choose a reason for hiding this comment

MarcoGorelli Aug 22, 2023

Choose a reason for hiding this comment

natmokval Aug 22, 2023

Choose a reason for hiding this comment

MarcoGorelli left a comment

Choose a reason for hiding this comment

natmokval commented Aug 25, 2023

MarcoGorelli commented Aug 29, 2023

natmokval commented Jul 10, 2023 •

edited

Loading

natmokval commented Jul 10, 2023 •

edited

Loading