BUG: fixes #53935 Categorical order lost after call to remove_categories #54027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. This allows the difference method to then call the _difference method and finally call the _maybe_try_sort method. In the _maybe_try_sort_method it will sort the values if sort is not False. That's why in the original code haveing sort=None would still sort the categories. This way the code will only sort if you set sort=True.
paulreece
changed the title
3 tasks
paulreece
changed the title
paulreece
changed the title
paulreece
changed the title
…andas-paulreece into categorical_sort_fix
mroeschke
requested changes
Jul 7, 2023
…s set to True, if so it sets sort=False in the call to difference in remove_categories.
mroeschke
reviewed
Jul 10, 2023
| @@ -1366,7 +1366,10 @@ def remove_categories(self, removals) -> Self: | |||
| removals = [removals] | |||
|
|
|||
| removals = Index(removals).unique().dropna() | |||
| new_categories = self.dtype.categories.difference(removals) | |||
There was a problem hiding this comment.
Can you just replace the if/else with difference(removals, sort=not self.dtype.ordered)?
mroeschke
reviewed
Jul 10, 2023
doc/source/whatsnew/v2.1.0.rst
Outdated
| @@ -371,6 +371,7 @@ Bug fixes | |||
|
|
|||
| Categorical | |||
| ^^^^^^^^^^^ | |||
| - Bug in :meth:`CategoricalIndex.remove_categories` , with categories it now retains the original order when removing an element from the categories list(:issue:`53935`). | |||
There was a problem hiding this comment.
Suggested change
| - Bug in :meth:`CategoricalIndex.remove_categories` , with categories it now retains the original order when removing an element from the categories list(:issue:`53935`). | |
| - Bug in :meth:`CategoricalIndex.remove_categories` where ordered categories would not be maintained (:issue:`53935`). |
There was a problem hiding this comment.
Just pushed up a commit that implements both suggestions. Thanks for your help!
There was a problem hiding this comment.
Unfortunately, that implementation you suggested failed the CI tests. I believe because we were overriding the default argument of None with True some of the time. I just uploaded a version using a Python Ternary to get this to a one liner. Let me know what you think.
…s set to True, if so it sets sort=False in the call to difference in remove_categories.
…eems to work better since we are not overriding a default argument this way.
mroeschke
approved these changes
Jul 11, 2023
|
Thanks @paulreece |
|
Great working with you, @mroeschke! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove_categories#53935I simply put an if/else in the
remove_categoriesmethod. Ifordered=Trueit will passsort=Falseinto the `difference1 method.