Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test CoW for multiple Python versions #53981

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Test CoW for multiple Python versions #53981

merged 2 commits into from
Jul 5, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Jul 3, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@phofl phofl requested a review from mroeschke as a code owner July 3, 2023 14:33
@jorisvandenbossche
Copy link
Member

We could also run a small subset on every build (like adding a step with PANDAS_COPY_ON_WRITE=1 pytest pandas/tests/copy_view). That avoids the build setup/install time for those additional builds

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Copy / view semantics labels Jul 4, 2023
@jorisvandenbossche jorisvandenbossche added this to the 2.1 milestone Jul 4, 2023
jorisvandenbossche
jorisvandenbossche approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can still do my suggestion later if we want more cross-platform testing

@phofl
Copy link
Member Author

phofl commented Jul 5, 2023

Yep, I'd add another stage in this case. But let's get this in so that we can rebase the fillna pr

@phofl phofl merged commit 1e90f9e into pandas-dev:main Jul 5, 2023
@phofl phofl deleted the cow_tests branch July 5, 2023 18:47
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@phofl
Test CoW for multiple Python versions (pandas-dev#53981)
bff3182
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees
No one assigned
Labels
Copy / view semantics Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @jorisvandenbossche