Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN : Removed unnecessary numba-compat code #53947

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

PrathumP
Copy link
Contributor

@PrathumP PrathumP commented Jun 30, 2023

@MarcoGorelli
Copy link
Member

can you run the code checks please?

@PrathumP
Copy link
Contributor Author

Yes, sure

@PrathumP
Copy link
Contributor Author

I ran tests fro this individual file and everything seems fine.

Screenshot_2023-05-28_17-10-26

Then, I ran code checks for all files and it also seems to be working fine.

Screenshot_2023-06-30_20-46-37

@MarcoGorelli
Copy link
Member

it fails in CI, so I guess you didn't commit?

@PrathumP
Copy link
Contributor Author

It was a insignificant change, it should pass CI now ig.

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jun 30, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @PrathumP

@MarcoGorelli MarcoGorelli merged commit dd16728 into pandas-dev:main Jun 30, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
* Removed unnecessary numba-compat code

* minor change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants