Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add test with freq=2M to increase coverage of to_period #53940

Merged

Conversation

natmokval
Copy link
Contributor

xref #52064

added a test in pandas/tests/indexes/datetimes/methods/test_to_period.py, which covers cases freq=“2M" and freq=MonthEnd(2) for to_period from DatetimeIndex. The reason: existing tests were all for "freq='M'", rather than for "freq='2M'".

@natmokval natmokval marked this pull request as ready for review June 30, 2023 07:55
@natmokval
Copy link
Contributor Author

@MarcoGorelli, could you please take a look at this pr?

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @natmokval , good to increase coverage here

@MarcoGorelli MarcoGorelli added the Needs Tests Unit test(s) needed to prevent regressions label Jun 30, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jun 30, 2023
@MarcoGorelli MarcoGorelli merged commit ad17842 into pandas-dev:main Jun 30, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants