Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: assorted #53932

Merged
merged 1 commit into from
Jun 29, 2023
Merged

CLN: assorted #53932

merged 1 commit into from
Jun 29, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

WillAyd
WillAyd approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work - looks great

@mroeschke mroeschke added this to the 2.1 milestone Jun 29, 2023
@mroeschke mroeschke merged commit 6eb59b3 into pandas-dev:main Jun 29, 2023
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the fixmes76 branch June 29, 2023 22:11
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@jbrockmendel
CLN: assorted (pandas-dev#53932)
eff369d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@WillAyd WillAyd WillAyd approved these changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @WillAyd