Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fixing EX01 - Added examples #53930

Merged
merged 8 commits into from
Jun 30, 2023
Merged

DOC: Fixing EX01 - Added examples #53930

merged 8 commits into from
Jun 30, 2023

Conversation

DeaMariaLeon
Copy link
Member

Towards #37875

@DeaMariaLeon DeaMariaLeon added this to the 2.1 milestone Jun 29, 2023
MarcoGorelli
MarcoGorelli reviewed Jun 30, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - couple of minor comments

pandas/core/groupby/groupby.py Outdated
... '2023-02-01',
... '2023-02-10',
... '2023-02-15']))
>>> print(ser.resample('MS').ohlc())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need the print statement? can be fixed up as part of a future PR anyway

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. (It looked weird in Jupyter without it)

pandas/core/resample.py Outdated

Parameters
----------
numeric_only : bool, default no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default False?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

pandas/core/resample.py Outdated

Parameters
----------
numeric_only : bool, default no
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likewise

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

MarcoGorelli
MarcoGorelli approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one, thanks @DeaMariaLeon

@MarcoGorelli MarcoGorelli merged commit 5949333 into pandas-dev:main Jun 30, 2023
@DeaMariaLeon DeaMariaLeon deleted the Jun29 branch June 30, 2023 09:53
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@DeaMariaLeon @mroeschke
DOC: Fixing EX01 - Added examples (pandas-dev#53930)
2390932 
* Examples Resampler.ohlc, prod, size, sem, std, sum, var

* Updated code_checks.sh

* Corrected sum docstring

* corrected default no, removed print

---------

Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@rhshadrach rhshadrach Awaiting requested review from rhshadrach rhshadrach is a code owner

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@DeaMariaLeon @MarcoGorelli @mroeschke