Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add the parameter MonthEnd(2) to 2 tests with freq= 2M #53916

Merged

Conversation

natmokval
Copy link
Contributor

xref #52064

added parametrization to 2 tests in which we pass freq = '2M' to check if they work correctly not only with str, but with offsets (MonthEnd(2)) as well.

@natmokval natmokval marked this pull request as ready for review June 29, 2023 06:33
@natmokval
Copy link
Contributor Author

@MarcoGorelli, could you please take a look at this pr?

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jun 29, 2023
@MarcoGorelli MarcoGorelli added Frequency DateOffsets Needs Tests Unit test(s) needed to prevent regressions labels Jun 29, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval !

@MarcoGorelli MarcoGorelli merged commit 81115d8 into pandas-dev:main Jun 29, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
…ev#53916)

TST: add the parameter MonthEnd(2) to some tests with freq= 2M
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets Needs Tests Unit test(s) needed to prevent regressions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants