Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add test with freq=2M for period_array from datetime64 #53890

Conversation

natmokval
Copy link
Contributor

@natmokval natmokval commented Jun 27, 2023

xref #52064

added a test in pandas/tests/arrays/period/test_constructors.py, which covers a case freq='2M' for period_array from datetime64. The reason: existing tests were all for "freq='M'", rather then for "freq='2M'".

@natmokval natmokval marked this pull request as ready for review June 28, 2023 06:50
@natmokval
Copy link
Contributor Author

@MarcoGorelli, could you please take a look at this pr? Seems like ci failures aren't related to my changes.

Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @natmokval !

@MarcoGorelli MarcoGorelli added the Needs Tests Unit test(s) needed to prevent regressions label Jun 28, 2023
@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jun 28, 2023
@MarcoGorelli MarcoGorelli added the Period Period data type label Jun 28, 2023
@MarcoGorelli MarcoGorelli merged commit 28a0c65 into pandas-dev:main Jun 28, 2023
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Tests Unit test(s) needed to prevent regressions Period Period data type
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants