Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added suggested new line to fix doc code example #53775

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Added suggested new line to fix doc code example #53775

merged 3 commits into from
Jun 21, 2023

Conversation

rahulsiloniya
Copy link
Contributor

@MarcoGorelli
Copy link
Member

can you remove the whitespace pls?

@rahulsiloniya
Copy link
Contributor Author

Sure thing but, then what is supposed to be changed in the docstring?

@MarcoGorelli
Copy link
Member

you need a blank line with no whitespace

@rahulsiloniya
Copy link
Contributor Author

Oh, okay

MarcoGorelli
MarcoGorelli approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rahulsiloniya

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Jun 21, 2023
@rahulsiloniya
Copy link
Contributor Author

Yay!! Looking forward to contribute some code to this repo.

@MarcoGorelli MarcoGorelli merged commit bb0403b into pandas-dev:main Jun 21, 2023
canthonyscott pushed a commit to canthonyscott/pandas-anthony that referenced this pull request Jun 23, 2023
@rahulsiloniya
Added suggested new line to fix doc code example (pandas-dev#53775)
59881f3 
* Added suggested new line to fix doc code example

* Removed the newline

* Done
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@rahulsiloniya
Added suggested new line to fix doc code example (pandas-dev#53775)
554899a 
* Added suggested new line to fix doc code example

* Removed the newline

* Done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

DOC: to_orc example doesn't render
2 participants
@rahulsiloniya @MarcoGorelli