-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add code-formatting and cross-reference links to read_csv
docstring
#53735
Conversation
read_csv
docstring
|
Thanks @mroeschke for the report on this. I am trying to have a closer look but ran into issue #53788 which I need to figure out before I can rebuild the docs I think. Also, just since I'm fairly new at this, is there a simple way to locate specific lines in a docstring (i.e. 176 and 178 that are being flagged)? It's not immediately obvious given that the docstring in the source code is built out of format strings (i.e. isn't a literal) so it makes it hard to know which lines are causing trouble just from reviewing the |
Hi @mroeschke, I located the error and fixed the formatting with the |
What is the meaning of the cancelled checks? Do I need to do something to re-run or was that intentional? |
Thanks @tpaxman. The canceled checks are due to some unit tests that are unrelated |
Sorry for chipping in @tpaxman. Though "pandas" is a module, IMHO it should not be enclosed in backticks here? I don't see it being considered inline code anywhere else in the docs either. (Just mentioning this because I see you making some doc contributions recently. Maybe you can make this change in one of your currently open PRs if you agree with my point). Some other suggestions
|
…tring (pandas-dev#53735) * apply appropriate code-formatting to `read_csv` docstring using backticks * escape curly braces for `dict` examples * fix formatting under `delim_whitespace` so that tab character appears properly * fix formatting issue in read_csv description for dtype_backend * test linking for :class:`~pandas.DataFrame` * add spinx references to pandas classes and functions * remove code formatting from initial parameter description lines in read_csv * replaced "default None" with "optional" in read_csv docstring * add additional code formatting changes to read_csv after review * shorten docstring lines to 88 characters max * fix formatting causing docstring error --------- Co-authored-by: tpaxman <[email protected]>
Thank you, @Charlie-XIAO! I agree with all your suggestions for sure. I was thinking about whether to convert that list of As for the formatting for the pandas module, I am not totally clear on what is preferred in the docs since I've seen instances of both plain text and code-formatted versions. That might be something the maintainers could advise on. And if there is a preferred format, it would be good to have that added to the developer guide as well. |
pandas.read_csv
for now).Added code formatting where applicable and added sphinx cross-referencing tags for any
pandas
classes or functions. Also cleaned up cases where "default None" was specified rather than "optional".Note: I plan to submit future PRs focused on editing the content (e.g., #53673) but wanted to start with the formatting changes.