ENH: Series.explode to support pyarrow-backed list types #53602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Reshaping
mroeschke
reviewed
Jun 12, 2023
| @@ -141,3 +143,25 @@ def test_explode_scalars_can_ignore_index(): | |||
| result = s.explode(ignore_index=True) | |||
| expected = pd.Series([1, 2, 3]) | |||
| tm.assert_series_equal(result, expected) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(pa_version_under7p0, reason="minimum pyarrow not installed") | |||
There was a problem hiding this comment.
Nit: Could you just use pa = pytest.importorskip("pyarrow") below?
mroeschke
reviewed
Jun 12, 2023
|
|
||
|
|
||
| @pytest.mark.skipif(pa_version_under7p0, reason="minimum pyarrow not installed") | ||
| def test_explode_pyarrow_list_type(): |
There was a problem hiding this comment.
Could you parameterize on ignore_index as well?
mroeschke
reviewed
Jun 13, 2023
mroeschke
approved these changes
Jun 13, 2023
|
Thanks @lukemanley |
canthonyscott
pushed a commit
to canthonyscott/pandas-anthony
that referenced
this pull request
Jun 23, 2023
…53602) * ENH: Series.explode to support pyarrow-backed list types * gh refs * update test
3 tasks
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…53602) * ENH: Series.explode to support pyarrow-backed list types * gh refs * update test
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.1.0.rstfile if fixing a bug or adding a new feature.