ENH: Groupby.transform support string input with engine=numba #53579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
force-pushed
the
numba-transform-str
branch
from
3572e06 to
45a2721
Compare
lithomas1
commented
Jun 9, 2023
|
|
||
| elif func not in base.transform_kernel_allowlist: | ||
| msg = f"'{func}' is not a valid function name for transform(name)" | ||
| raise ValueError(msg) | ||
| elif func in base.cythonized_kernels or func in base.transformation_kernels: | ||
| # cythonized transform or canned "agg+broadcast" | ||
| if engine is not None: |
There was a problem hiding this comment.
Since there are no transformation kernels(e.g. cumsum, shift etc.) for numba yet, this is untested.
Should be OK, though, since this didn't work before anyways.
There was a problem hiding this comment.
Curious, what type of error do we get when we pass engine="cython", engine_kwargs={"nogil": True}?
There was a problem hiding this comment.
IIRC, it gives something like
Groupby.method() got an unexpected argument engine
lithomas1
commented
Jun 9, 2023
| @td.skip_if_no("numba") | ||
| @pytest.mark.parametrize( | ||
| "agg_func", [["min", "max"], "min", {"B": ["min", "max"], "C": "sum"}] | ||
| ) | ||
| def test_multifunc_notimplimented(agg_func): |
There was a problem hiding this comment.
Had to change the test since multifuncs (list/dicts of funcs) aren't supported anyways in transform for the cython engine as well.
mroeschke
approved these changes
Jun 12, 2023
|
Thanks @lithomas1 |
canthonyscott
pushed a commit
to canthonyscott/pandas-anthony
that referenced
this pull request
Jun 23, 2023
…-dev#53579) * ENH: Groupby.transform support string input with engine=numba * remove xfail
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
…-dev#53579) * ENH: Groupby.transform support string input with engine=numba * remove xfail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.