DEPR: pd.value_counts #53493
Merged
DEPR: pd.value_counts #53493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 6, 2023
doc/source/whatsnew/v0.19.2.rst
Outdated
| @@ -7,6 +7,7 @@ Version 0.19.2 (December 24, 2016) | |||
|
|
|||
| .. ipython:: python | |||
| :suppress: | |||
| :okwarning: | |||
There was a problem hiding this comment.
So a star import will raise the FutureWarning from pd.value_counts? That's kinda unfortunate as it seems noisy
There was a problem hiding this comment.
i dont see an alternative that isnt behavior-changing
There was a problem hiding this comment.
i guess could warn inside value_counts if it is called
There was a problem hiding this comment.
Yeah I think it's more directly useful to warn users who are using pd.value_counts directly`
mroeschke
approved these changes
Jun 12, 2023
|
Thanks @jbrockmendel |
canthonyscott
pushed a commit
to canthonyscott/pandas-anthony
that referenced
this pull request
Jun 23, 2023
* DEPR: pd.value_counts * update docs * suppress warning * suppress warning * suppress warning * suppress warning * pyright ignore * pylint ignore * warn inside value_counts
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
* DEPR: pd.value_counts * update docs * suppress warning * suppress warning * suppress warning * suppress warning * pyright ignore * pylint ignore * warn inside value_counts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.