Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPR: inplace in GroupBy.fillna #53438

Closed
wants to merge 1 commit into from
Closed

DEPR: inplace in GroupBy.fillna #53438

wants to merge 1 commit into from

Conversation

rhshadrach
Copy link
Member

@rhshadrach rhshadrach added Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Deprecate Functionality to remove in pandas Transformations e.g. cumsum, diff, rank labels May 29, 2023
jbrockmendel
jbrockmendel reviewed May 30, 2023
View reviewed changes
pandas/tests/groupby/test_function.py
):
result = gb.fillna(method="ffill", inplace=inplace)
if inplace and inplace is not lib.no_default:
expected = Series([None, None], dtype=object, index=[1, 2])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you need to specify index dtype for windows/32bit builds

@rhshadrach rhshadrach mentioned this pull request Jun 2, 2023
Merged
5 tasks
@rhshadrach
Copy link
Member Author

Closing in favor of #53496

@rhshadrach rhshadrach closed this Jun 3, 2023
@rhshadrach rhshadrach deleted the depr_gb_fillna_inplace branch September 27, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Deprecate Functionality to remove in pandas Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Transformations e.g. cumsum, diff, rank
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEPR: inplace in DataFrameGroupBy.fillna and SeriesGroupBy.fillna
2 participants
@rhshadrach @jbrockmendel